[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches |
|
Date: |
Thu, 08 May 2014 10:16:18 +0200 |
On Mi, 2014-05-07 at 23:41 +0100, Hani Benhabiles wrote:
> Compared to v1:
> * Dropped patch 02/07 for help completion conversion.
> * Nothing else changed. 04,05 and 06 are R-b by Stefan.
>
> Hani Benhabiles (6):
> monitor: Convert sendkey to use command_completion.
> monitor: Add chardev-remove command completion.
> monitor: Add chardev-add backend argument completion.
Don't know much about readline completion internals, but the way the
valid choices are figured in these three patches looks sane to me.
cheers,
Gerd
- [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches, Hani Benhabiles, 2014/05/07
- [Qemu-devel] [PATCH 1/6] monitor: Convert sendkey to use command_completion., Hani Benhabiles, 2014/05/07
- [Qemu-devel] [PATCH 2/6] monitor: Add chardev-remove command completion., Hani Benhabiles, 2014/05/07
- [Qemu-devel] [PATCH 4/6] monitor: Add set_link arguments completion., Hani Benhabiles, 2014/05/07
- [Qemu-devel] [PATCH 3/6] monitor: Add chardev-add backend argument completion., Hani Benhabiles, 2014/05/07
- [Qemu-devel] [PATCH 5/6] monitor: Add netdev_add type argument completion., Hani Benhabiles, 2014/05/07
- [Qemu-devel] [PATCH 6/6] monitor: Add netdev_del id argument completion., Hani Benhabiles, 2014/05/07
- Re: [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches, Luiz Capitulino, 2014/05/15
- Re: [Qemu-devel] [PATCH 0/6] Miscellaneous command completion patches, Hani Benhabiles, 2014/05/15