qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/4] block: Allow JSON filenames


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH 3/4] block: Allow JSON filenames
Date: Tue, 06 May 2014 22:29:28 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 06.05.2014 22:28, Eric Blake wrote:
On 05/06/2014 02:00 PM, Max Reitz wrote:

-drive
file='json:{"driver":"qcow2","file.filename":"foo","backing.file.driver":"raw"}',backing.file.driver=qcow2


looks like it specifies conflicting backing.file.driver options.
Passing true means that qdict_join silently overwrites the value in
options to instead be the value in the json string; passing false means
you could flag the user error.
Yes, you're right; I'll change it.
And of course, bonus points if you enhance the testsuite to provoke the
error and prove we detect it :)

Already done. ;-)

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]