Re: [Qemu-devel] [PATCH 0/7] Miscellaneous command completion patches

[Luiz Capitulino]

On Sun, 27 Apr 2014 17:00:01 +0100
Hani Benhabiles <address@hidden> wrote:

> Compared to the larger series sent before:
> * Patches 01-03 are already in qmp branch.
> * Added patches to convert sendkey, help/? to use new completion callback.
> * Dropped patch 06 (cpu index completion) as deemed not useful enough.
> * netdev_add now uses the same values array as qapi instead of hardcoding 
> them.
> * Left patches 10-17 for a separate series to make review process faster.
> * wrt. to Luiz' question about set_link patch: It prints both backend and
>   frontend values because both are accepted by set_link command.
> 
> Hani Benhabiles (7):
>   monitor: Convert sendkey to use command_completion.
>   monitor: Convert help|? to use command_completion.
>   monitor: Add chardev-remove command completion.
>   monitor: Add chardev-add backend argument completion.
>   monitor: Add set_link arguments completion.
>   monitor: Add netdev_add type argument completion.
>   monitor: Add netdev_del id argument completion.

The first patch looks good. The second one has a problem. For the other
patches it would help me to get Reviewed-bys by the following people:

 o Gerd: patch 03/07 and patch 04/07
 o Stefan: patches 05/07, 06/07 and 07/07