[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/13] qapi: Normalize marshalling's visitor ini
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 02/13] qapi: Normalize marshalling's visitor initialization and cleanup |
Date: |
Mon, 05 May 2014 08:32:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/02/2014 06:44 AM, Markus Armbruster wrote:
> Input and output marshalling functions do it differently. Change them
> to work the same: initialize the I/O visitor, use it, clean it up,
> initialize the dealloc visitor, use it, clean it up.
>
> This delays dealloc visitor initialization in output marshalling
> functions, and input visitor cleanup in input marshalling functions.
> No functional change, but the latter will be convenient when I change
> the error handling.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> docs/qapi-code-gen.txt | 8 ++++----
> scripts/qapi-commands.py | 27 ++++++++++++---------------
> 2 files changed, 16 insertions(+), 19 deletions(-)
Tracking what the changes do in the examples certainly made it easier to
review. Thanks.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 04/13] qapi: Replace start_optional()/end_optional() by optional(), (continued)
- [Qemu-devel] [PATCH 04/13] qapi: Replace start_optional()/end_optional() by optional(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 08/13] qapi: Un-inline visit of implicit struct, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 03/13] qapi: Remove unused Visitor callbacks start_handle(), end_handle(), Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 09/13] hmp: Call visit_end_struct() after visit_start_struct() succeeds, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 02/13] qapi: Normalize marshalling's visitor initialization and cleanup, Markus Armbruster, 2014/05/02
- Re: [Qemu-devel] [PATCH 02/13] qapi: Normalize marshalling's visitor initialization and cleanup,
Eric Blake <=
- [Qemu-devel] [PATCH 05/13] qapi-visit.py: Clean up confusing push_indent() / pop_indent() use, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 12/13] qapi: Replace uncommon use of the error API by the common one, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 06/13] qapi: Clean up shadowing of parameters and locals in inner scopes, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 07/13] qapi-visit.py: Clean up a sloppy use of field prefix, Markus Armbruster, 2014/05/02
- [Qemu-devel] [PATCH 13/13] error: error_is_set() is finally unused; remove, Markus Armbruster, 2014/05/02