[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/7] glib: move g_poll() repla
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/7] glib: move g_poll() replacement into glib-compat.h |
Date: |
Sat, 03 May 2014 13:11:51 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.4.0 |
02.05.2014 18:35, Michael Tokarev wrote:
> From: Stefan Hajnoczi <address@hidden>
>
> We have a dedicated header file for wrappers to smooth over glib version
> differences. Move the g_poll() definition into glib-compat.h for
> consistency.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Michael Tokarev <address@hidden>
> Cc: address@hidden
Applied to -trivial, thanks!
/mjt
> include/glib-compat.h | 12 ++++++++++++
> include/qemu-common.h | 12 ------------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/include/glib-compat.h b/include/glib-compat.h
> index 8aa77af..8d25900 100644
> --- a/include/glib-compat.h
> +++ b/include/glib-compat.h
> @@ -24,4 +24,16 @@ static inline guint g_timeout_add_seconds(guint interval,
> GSourceFunc function,
> }
> #endif
>
> +#if !GLIB_CHECK_VERSION(2, 20, 0)
> +/*
> + * Glib before 2.20.0 doesn't implement g_poll, so wrap it to compile
> properly
> + * on older systems.
> + */
> +static inline gint g_poll(GPollFD *fds, guint nfds, gint timeout)
> +{
> + GMainContext *ctx = g_main_context_default();
> + return g_main_context_get_poll_func(ctx)(fds, nfds, timeout);
> +}
> +#endif
> +
> #endif
> diff --git a/include/qemu-common.h b/include/qemu-common.h
> index a998e8d..3f3fd60 100644
> --- a/include/qemu-common.h
> +++ b/include/qemu-common.h
> @@ -124,18 +124,6 @@ int qemu_main(int argc, char **argv, char **envp);
> void qemu_get_timedate(struct tm *tm, int offset);
> int qemu_timedate_diff(struct tm *tm);
>
> -#if !GLIB_CHECK_VERSION(2, 20, 0)
> -/*
> - * Glib before 2.20.0 doesn't implement g_poll, so wrap it to compile
> properly
> - * on older systems.
> - */
> -static inline gint g_poll(GPollFD *fds, guint nfds, gint timeout)
> -{
> - GMainContext *ctx = g_main_context_default();
> - return g_main_context_get_poll_func(ctx)(fds, nfds, timeout);
> -}
> -#endif
> -
> /**
> * is_help_option:
> * @s: string to test
>
- [Qemu-devel] [PATCH v2 0/7] glib thread interface and libcacard cleanups, Michael Tokarev, 2014/05/02
- [Qemu-devel] [PATCH v2 2/7] glib: move g_poll() replacement into glib-compat.h, Michael Tokarev, 2014/05/02
- Re: [Qemu-devel] [Qemu-trivial] [PATCH v2 2/7] glib: move g_poll() replacement into glib-compat.h,
Michael Tokarev <=
- [Qemu-devel] [PATCH v2 1/7] do not call g_thread_init() for glib >= 2.31, Michael Tokarev, 2014/05/02
- [Qemu-devel] [PATCH v2 4/7] vscclient: use glib thread primitives not qemu, Michael Tokarev, 2014/05/02
- [Qemu-devel] [PATCH v2 3/7] glib-compat.h: add new thread API emulation on top of pre-2.31 API, Michael Tokarev, 2014/05/02
- [Qemu-devel] [PATCH v2 6/7] libcacard: replace qemu thread primitives with glib ones, Michael Tokarev, 2014/05/02
- [Qemu-devel] [PATCH v2 5/7] libcacard: replace pstrcpy() with memcpy(), Michael Tokarev, 2014/05/02
- [Qemu-devel] [PATCH v2 7/7] libcacard: actually use symbols file, Michael Tokarev, 2014/05/02