qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 13/31] block: Remove BDRV_O_COPY_ON_READ for bs->file


From: Kevin Wolf
Subject: [Qemu-devel] [PULL 13/31] block: Remove BDRV_O_COPY_ON_READ for bs->file
Date: Wed, 30 Apr 2014 20:23:45 +0200

Copy on Read makes sense on the format level where backing files are
implemented, but it's not required on the protocol level. While it
shouldn't actively break anything to have COR enabled on both layers,
needless serialisation and allocation checks may impact performance.

Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
 block.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index c6d5ab9..9f88bcc 100644
--- a/block.c
+++ b/block.c
@@ -793,7 +793,7 @@ static int bdrv_inherited_flags(int flags)
     }
 
     /* Clear flags that only apply to the top layer */
-    flags &= ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING);
+    flags &= ~(BDRV_O_SNAPSHOT | BDRV_O_NO_BACKING | BDRV_O_COPY_ON_READ);
 
     return flags;
 }
-- 
1.8.3.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]