[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 01/18] target-i386: kvm: Don't enable MONITOR by
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PATCH v4 01/18] target-i386: kvm: Don't enable MONITOR by default on any CPU model |
Date: |
Wed, 30 Apr 2014 13:48:28 -0300 |
KVM never supported the MONITOR flag so it doesn't make sense to have it
enabled by default when KVM is enabled.
The rationale here is similar to the cases where it makes sense to have
a feature enabled by default on all CPU models when on KVM mode (e.g.
x2apic). In this case we are having a feature disabled by default for
the same reasons.
In this case we don't need machine-type compat code because it is
currently impossible to run a KVM VM with the MONITOR flag set.
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
target-i386/cpu.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 8fd1497..7ec706f 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -372,6 +372,12 @@ static uint32_t kvm_default_features[FEATURE_WORDS] = {
[FEAT_1_ECX] = CPUID_EXT_X2APIC,
};
+/* Features that are not added by default to any CPU model when KVM is enabled.
+ */
+static uint32_t kvm_default_unset_features[FEATURE_WORDS] = {
+ [FEAT_1_ECX] = CPUID_EXT_MONITOR,
+};
+
void x86_cpu_compat_disable_kvm_features(FeatureWord w, uint32_t features)
{
kvm_default_features[w] &= ~features;
@@ -1885,6 +1891,7 @@ static void x86_cpu_load_def(X86CPU *cpu,
X86CPUDefinition *def, Error **errp)
FeatureWord w;
for (w = 0; w < FEATURE_WORDS; w++) {
env->features[w] |= kvm_default_features[w];
+ env->features[w] &= ~kvm_default_unset_features[w];
}
}
--
1.9.0
- [Qemu-devel] [PATCH v4 05/18] target-i386: Isolate KVM-specific code on CPU feature filtering logic, (continued)
- [Qemu-devel] [PATCH v4 05/18] target-i386: Isolate KVM-specific code on CPU feature filtering logic, Eduardo Habkost, 2014/04/30
- [Qemu-devel] [PATCH v4 03/18] target-i386: Merge feature filtering/checking functions, Eduardo Habkost, 2014/04/30
- [Qemu-devel] [PATCH v4 08/18] target-i386: Filter KVM and 0xC0000001 features on TCG, Eduardo Habkost, 2014/04/30
- [Qemu-devel] [PATCH v4 02/18] target-i386: Simplify reporting of unavailable features, Eduardo Habkost, 2014/04/30
- [Qemu-devel] [PATCH v4 04/18] target-i386: Pass FeatureWord argument to report_unavailable_features(), Eduardo Habkost, 2014/04/30
- [Qemu-devel] [PATCH v4 07/18] target-i386: Filter FEAT_7_0_EBX TCG features too, Eduardo Habkost, 2014/04/30
- [Qemu-devel] [PATCH v4 14/18] target-i386: Add "migratable" property to "host" CPU model, Eduardo Habkost, 2014/04/30
- [Qemu-devel] [PATCH v4 16/18] savevm: check vmsd for migratability status, Eduardo Habkost, 2014/04/30
- [Qemu-devel] [PATCH v4 18/18] target-i386: support "invariant tsc" flag, Eduardo Habkost, 2014/04/30
- [Qemu-devel] [PATCH v4 15/18] target-i386: Set migratable=yes by default, Eduardo Habkost, 2014/04/30
- [Qemu-devel] [PATCH v4 01/18] target-i386: kvm: Don't enable MONITOR by default on any CPU model,
Eduardo Habkost <=