qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 07/16] tcg-ppc64: DefineTCG_TARGET_INSN_UNIT_


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v3 07/16] tcg-ppc64: DefineTCG_TARGET_INSN_UNIT_SIZEE
Date: Tue, 29 Apr 2014 07:29:28 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 04/29/2014 04:25 AM, Alex Bennée wrote:
>> +static void reloc_pc24(tcg_insn_unit *pc, tcg_insn_unit *target)
>>  {
>> -    *(uint32_t *)pc = (*(uint32_t *)pc & ~0x3fffffc)
>> -        | reloc_pc24_val(pc, target);
>> +    *pc = (*pc & ~0x3fffffc) | reloc_pc24_val(pc, target);
>>  }
> 
> Should 0x3fffffc be a #define'd mask? Can the PC ever actually be
> non-word aligned?

No, it can't be unaligned.  The 0x3fffffc is really the field into
which the offset is being placed.  I don't think a define is helpful
really, since this is the only place it's used.


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]