Re: [Qemu-devel] [PATCH 1/8] kvm: reset state from the CPU's reset method

[Andreas Färber]

Am 29.04.2014 13:54, schrieb Paolo Bonzini:
> Now that we have a CPU object with a reset method, it is better to
> keep the KVM reset close to the CPU reset.  Using qemu_register_reset
> as we do now keeps them far apart.
> 
> With this patch, ARM and PPC no longer call the kvm_arch_ function, so
> it can get removed there.  i386 and s390x call it from X86CPU/S390CPU
> reset handler, and the function gets an X86CPU/S390CPU.
> 
> Note that s390-specific functions are called kvm_s390_*, while
> x86-specific functions are called kvm_arch_*, so this series only
> renames the S390 kvm_arch_reset_vcpu.  Changing that is the topic of a
> separate patch.
> 
> Reviewed-by: Gleb Natapov <address@hidden>
> Reviewed-by: Andreas Färber <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  include/sysemu/kvm.h   |  2 --
>  kvm-all.c              | 11 -----------
>  target-i386/cpu.c      |  5 +++++
>  target-i386/kvm.c      |  3 +--
>  target-i386/kvm_i386.h |  1 +
>  target-ppc/kvm.c       |  4 ----
>  target-s390x/cpu.c     |  4 ++++
>  target-s390x/cpu.h     |  5 +++++
>  target-s390x/kvm.c     |  6 ++++--
>  9 files changed, 20 insertions(+), 21 deletions(-)

Contrary to the commit message, the patch does not update target-arm/,
did you check whether it compiles there? kvm_arch_reset_vcpu() is
present in kvm32.c and kvm64.c, with only the latter being empty.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg