Re: [Qemu-devel] [PATCH] Makefile: Fix per-object variables for Makefile.target

[Michael Tokarev]

29.04.2014 07:29, Fam Zheng wrote:
> The compiling is done in a subdir, so the extraction of per-object libs
> and cflags are referencing objects with ../ prefixed. So prefix the
> per-object variables "foo.o-cflags" and "foo.o-libs" to
> "../foo.o-cflags" and "../foo.o-libs".
> 
> Signed-off-by: Fam Zheng <address@hidden>

Reviewed-by: Michael Tokarev <address@hidden>

This keeps target-specific object variables working, too.

But seriously, guys, this complexity/trickery is just insane.
We don't have that many objects in our tree, maybe, just maybe,
it will be better to return back to our old idea where all
objects are specified by their full path within source tree,
like block/foo.o, instead of stripping the subdir part within
a subdir and adding it back using this trickery?

To my opinion, the amount of work required to maintain the
trickery, and the fact that no one, even Fam, actually
understands how it works, way outperforms time/enegry
needed to support flat, trickery-less, full-path object
lists.

I will gladly give some time to re-write the build system
to make it subdir-ful trickery-less, and at the same time
keep it bisectable, if the agreement will be to do that.

Because, really, the current system is insane...

Thanks,

/mjt