Re: [Qemu-devel] [PATCH 01/14] dma: Convert conditional compilation of debug printfs to regular ifs

[Andreas Färber]

Am 28.04.2014 13:21, schrieb Peter Crosthwaite:
> Hi Marc,
> 
> On such a long series, it's usual to include a cover letter
> summarising the entire series. Its subject is "PATCH 00/NN" and can be
> generated by adding the --cover-letter switch to git send-email. Hand
> edit the file them send along with the autogenerated patches.
> 
> On Mon, Apr 28, 2014 at 6:26 PM, Marc Marí <address@hidden> wrote:
>> From: Marc Marí <address@hidden>
>>
>> Modify debug macros as explained in 
>> https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03642.html
> 
> Wrap the body of the commit message to 72 chars, it's ok to blow the
> limit for a long URL IMO but you should at least line break between
> "in" "https".

Or better drop that reference at all. The archives are not kept forever,
so any essential explanation should go into the commit message proper.
In this case, a copied&pasted "This avoids code bitrotting." or so would
be sufficient as the pattern is obvious from looking at the diff and
mentioned in the subject.

On that matter, there is no "dma" subsystem. There's i82374, which is
part of PReP. i8257 is a core PC thing, not sure if that means mst?
Don't know about rc4030.
Anyway, this series is clearly not divided by maintenance areas and not
CC'ing the appropriate maintainers - Marc, please use:

git config sendemail.cccmd "scripts/get_maintainer.pl --nogit-fallback"

to CC the maintainers documented in MAINTAINERS file.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg