[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] mirror: Use DIV_ROUND_UP
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH] mirror: Use DIV_ROUND_UP |
|
Date: |
Mon, 28 Apr 2014 14:11:45 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 28.04.2014 um 04:59 hat Fam Zheng geschrieben:
> Although bdrv_getlength() was just called above this, and checked for
> error, it is better to just use the value we already get, and use
> DIV_ROUND_UP.
>
> Signed-off-by: Fam Zheng <address@hidden>
The subject line is kind of hiding the real intention of the patch,
which appears to be getting rid of a bdrv_getlength() call without error
checks.
Anyway, the patch itself looks fine, applied to the block branch.
Kevin