Re: [Qemu-devel] [PATCH 03/14] net: Convert conditional compilation of debug printfs to regular ifs

[Marc Marí]

I left the original definition as it was, just adding the "1", that's why there is so much diversity. I'll remove them for v2.

2014-04-28 12:10 GMT+02:00 Stefan Hajnoczi <address@hidden>:

On Mon, Apr 28, 2014 at 10:26:04AM +0200, Marc Marí wrote:
>  /* Debug EEPRO100 card. */
>  #if 0
> -# define DEBUG_EEPRO100
> +#define DEBUG_EEPRO100 1
>  #endif

There seem to be a few ways of doing this (commenting out the line,
putting it in #if 0, etc).

Feel free to get rid of #define DEBUG_foo 1 lines completely, leaving
just the #ifndef (I think Kevin suggested this).

Editing the file is bad since it's easy to forget to remove changes when
doing git-commit(1).  Debugging should be enabled by recompiling instead
of editing source files:
$ ./configure --extra-cflags=-DDEBUG_FOO=1 && make

But this is just a personal preference, if you want to leave the lines
it's fine.

Stefan