Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file

[Michael Tokarev]

27.04.2014 17:35, Paolo Bonzini пишет:
> 
> 
> ----- Messaggio originale -----
>> Da: "Michael Tokarev" <address@hidden>
>> A: "Paolo Bonzini" <address@hidden>, "Alon Levy" <address@hidden>
>> Cc: address@hidden
>> Inviato: Domenica, 27 aprile 2014 14:59:45
>> Oggetto: Re: [Qemu-devel] [PATCH] libcacard: actually use the symbols file
>>
>> 27.04.2014 13:54, Paolo Bonzini wrote:
>>> Il 27/04/2014 10:10, Michael Tokarev ha scritto:
>> []
>>>> Well.   vscclient explicitly uses them in the code, but only links with
>>>> libcacard, not with other qemu objects.  So adding proper qemu objects
>>>> here should be fine.  I can take care of that.
>>>>
>>>> On the other hand, some of those are mutexes, shouldn't the same objects
>>>> be used inside the library and inside the executable?  I don't know.
>>>
>>> vscclient should link to libqemuutil.a.
> 
> ... and libqemustub.a (I thought it already did that).

Aha.  That one works.  (Nope, vscclient only linked with libcacard.la
previously, just its main object and libcacard.la).

So now, with proper symbols exported by libcacard.so, and adding
libqemuutil.a and libqemustub.a, that's what I'm getting on x86_64:

   text    data     bss     dec     hex filename
  17797    1440     560   19797    4d55 vscclient-orig-libcacard-only
  47814    2072    4776   54662    d586 vscclient-libcacard+qemuutil+stubs

That's more than 2x the size difference!.. ;)  (stripped)

Most stuff being added from libqemuutul.a and libqemustub.a is already
linked to libcacard.so, but with proper symbol exporting it remains
private.

Oh well.

So, what do we do here?  Should we actually enable proper exporting?

/mjt