Re: [Qemu-devel] [PATCH 0/3] monitor: Improve command completion

[Hani Benhabiles]

On Fri, Apr 25, 2014 at 09:48:33AM -0400, Luiz Capitulino wrote:
> On Sun, 13 Apr 2014 16:25:04 +0100
> Hani Benhabiles <address@hidden> wrote:
> 
> > This patch series adds a new callback to mon_cmd_t which will make adding
> > completion support for more commands cleaner.
> > 
> > It moves some existing commands completions to using the new callback and 
> > also
> > fixes the completion for device_add and drive_del commands.
> > 
> > Hani Benhabiles (3):
> >   monitor: Fix drive_del id argument type completion.
> >   monitor: Add command_completion callback to mon_cmd_t.
> >   monitor: Add device_add and device_del completion.
> > 
> >  hmp-commands.hx |  6 +++++-
> >  hmp.h           |  5 +++++
> >  monitor.c       | 57 
> > +++++++++++++++++++++++++++++++++++++--------------------
> >  3 files changed, 47 insertions(+), 21 deletions(-)
> 
> Applied to the qmp branch, but sendkey conversion is missing. Not sure
> we can convert help too.

Thanks. Will take a look at them.