[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] disas/libvixl: update to upstream 1.3
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] disas/libvixl: update to upstream 1.3 |
Date: |
Fri, 25 Apr 2014 10:06:34 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/25/2014 12:15 AM, Christoffer Dall wrote:
>> > Possible options:
>> > (a) apply these patches, and live with the bisection
>> > break on 32 bit hosts
>> > (b) squash all these patches together into a single
>> > commit, avoiding the bisection break but losing the
>> > ability to see the local changes
>> > (c) add a patch at the start which nobbles configure
>> > to never set CONFIG_ARM_A64_DIS=y, and then another
>> > at the end which reenables it
>> >
>> > Opinions?
>> >
> I think being able to easily distinguish the pristine upstream files
> from the QEMU versions and point out local changes is absolutely
> important to maintain some sort of integration between these two open
> source projects.
>
> I can live with (a), but option (c) does seem to be an improvement on
> that with no additional disadvantages.
Agreed.
r~