Re: [Qemu-devel] [PATCH] qmp: Remove unused variable.

[Luiz Capitulino]

On Tue, 22 Apr 2014 22:44:03 +0100
Hani Benhabiles <address@hidden> wrote:

> Signed-off-by: Hani Benhabiles <address@hidden>
> ---
>  qmp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/qmp.c b/qmp.c
> index 87a28f7..44a6e17 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -194,11 +194,10 @@ void qmp_system_wakeup(Error **errp)
>  ObjectPropertyInfoList *qmp_qom_list(const char *path, Error **errp)
>  {
>      Object *obj;
> -    bool ambiguous = false;
>      ObjectPropertyInfoList *props = NULL;
>      ObjectProperty *prop;
>  
> -    obj = object_resolve_path(path, &ambiguous);
> +    obj = object_resolve_path(path, NULL);
>      if (obj == NULL) {
>          error_set(errp, QERR_DEVICE_NOT_FOUND, path);
>          return NULL;

I'm under the impression that this check in object_resolve_partial_path():

        if (ambiguous && *ambiguous) {
            return NULL;
        }

Uses 'ambiguous' internally. In that case, this change could have a side effect.

But I'm not sure, I think it would be good to get a reviewed-by from
a QOM expert.