[Qemu-devel] [PATCH 00/13] __{get,put}_user return value cleanup

[riku . voipio]

From: Riku Voipio <address@hidden>

This series is primarily motivated to have a gcc-4.9 buildfix:

linux-user/syscall.c: In function ‘host_to_target_stat64’:
linux-user/qemu.h:301:19: error: right-hand operand of comma expression has no 
effect [-Werror=unused-value]
      ((hptr), (x)), 0)

removing the unused 0 moves the bar:

linux-user/main.c: In function ‘arm_kernel_cmpxchg64_helper’:
linux-user/qemu.h:330:15: error: void value not ignored as it ought to be
         __ret = __put_user((x), __hptr);    \

And after fixing that, we see there is a lot of reading the return
value of __put_user and __get_user in signal.c - apparently without
much of consistency as other functions do check and others don't...

I'm not 100% sure that simply removing the checks is right way
and signal.c is quite a mess, so push this set early for comments
before spending more time on this approach.

Riku Voipio (13):
  signal.c: remove __get/__put_user return value reading
  signal.c setup_frame/x86: __put_user cleanup
  signal.c: remove return value from copy_siginfo_to_user
  signal.c: remove return value from setup_sigcontext
  signal.c: remove return value from restore_sigcontext
  RFC comment out restore_fpu_state (sparc)
  do_sigaltstack: remove __get_user value check
  do_sigreturn - remove __get_user checks
  signal.c: setup_frame remove __put_user checks
  remove __put/get error checks from ppc {save,restore}_user_regs
  sparc64_set_context: remove __get_user checks
  remove __get_user return check from PPC do_setcontext
  fix gcc-4.9 compiler error on __{get,put]}_user

 linux-user/qemu.h   |   12 +-
 linux-user/signal.c | 1221 +++++++++++++++++++++------------------------------
 2 files changed, 515 insertions(+), 718 deletions(-)

-- 
1.9.2