|
From: | Don Slutz |
Subject: | Re: [Qemu-devel] [PATCH v3 2/4] GlobalProperty: Display warning about unused -global |
Date: | Wed, 23 Apr 2014 08:58:05 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 04/22/14 20:28, Paolo Bonzini wrote:
Il 22/04/2014 19:13, Don Slutz ha scritto:Even then, I suspect sooner or later machines other than PC and Q35 will be versioned. At that point we'll probably want QEMU-global compat_props that automatically apply to all machines, even if a type is not missing. I think we should already approximate this behavior by allowing machine .compat_props where the type doesn't exist.If I am reading this correctly, this is asking that .compat_props to not be reported. This currently happens because of not_used being false in all C99 struct initializations.Oh, I see. That's obvious in retrospect, but perhaps a comment can be useful around the definition of the not_used field.
Will add a comment: /** * GlobalProperty:* @not_used: Track use of a global property. Defaults to false in all C99 struct initializations.
* * This prevents reports of .compat_props when they are not used. */ (Not sure if this is the correct formatting.) -Don Slutz
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |