[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] qemu-img: Improve error messages
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3] qemu-img: Improve error messages |
Date: |
Tue, 22 Apr 2014 14:00:51 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 22.04.2014 um 07:36 hat Fam Zheng geschrieben:
> Previously, when there is a user error in argv parsing, qemu-img prints
> help text and exits.
>
> Add an error_exit function to print a helpful error message and a hint
> to run 'qemu-img --help' for more information.
>
> As a bonus, "qemu-img <cmd> --help" now has a more reasonable exit code
> 0.
>
> In the future the help text should be split by sub command, and only
> print the information for the specified command.
>
> Signed-off-by: Fam Zheng <address@hidden>
>
> ---
> v3: Remove "return 0" in the end of main. (Sen)
> v2: Address Eric's comments on QEMU_NORETURN, article and
> EXIT_{SUCCEESS,FAILURE}.
>
> Signed-off-by: Fam Zheng <address@hidden>
Thanks, applied to the block branch.
Kevin