Re: [Qemu-devel] [PULL 2/2] usb: mtp filesharing

[Eric Blake]

On 04/22/2014 06:03 AM, Gerd Hoffmann wrote:
> Implementation of a USB Media Transfer Device device for easy
> filesharing.  Read-only.  No access control inside qemu, it will
> happily export any file it is able to open to the guest, i.e.
> standard unix access rights for the qemu process apply.
> 
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---

> +++ b/hw/usb/dev-mtp.c
> @@ -0,0 +1,1100 @@
> +/*
> + * Media Transfer Protocol implementation, backed by host filesystem.
> + *
> + * Written by Gerd Hoffmann <address@hidden>
> + *
> + * This code is licensed under the GPLv2+.

No other file in the code base says this (many say "under the GPL v2 or
later", or similar, but none have abbreviated to GPLv2+).  Furthermore,
aren't you missing a "Copyright" line?  My (non-lawyer) understanding of
the GPL is that the license works only for files where you have claimed
copyright.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature