[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive)
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive) |
Date: |
Mon, 21 Apr 2014 17:43:03 +0100 |
On 21 April 2014 17:31, Juan Quintela <address@hidden> wrote:
> Patches are easy to review in sequence, any of them is very simple, and
> the few ones that are long (minimum_version_id_old) review is just
> looking that the previous line is minimum_version_id = <same number>.
But there are simply _far too many_ of them in this series.
For instance "remove minimum_version_id_old" should be a series
by itself: it is self contained and can be reviewed and committed
much more easily that way. It seems likely that there are three or
four other things also going on in this set of patches.
"Improve the vmstate tests" should also be a separate patchset.
I'm not sure about merging the field versioning with the field test
function stuff, but I'm not about to try to fish the relevant patches
out of this enormous mess so I'll wait until they appear in a series
of their own before I comment on them.
You mention at least one bugfix of some kind: that ought to be
its own patch or patchset.
Even 40 patches or so in a set is pushing the boundaries of
what is reasonably reviewable in my opinion.
thanks
-- PMM
- [Qemu-devel] [PATCH 119/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_INT32, (continued)
- [Qemu-devel] [PATCH 119/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_INT32, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 120/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_POINTER_UINT16, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 121/124] vmstate: Test for VMSTATE_STRUCT_ARRAY_POINTER_UINT32, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 122/124] vmstate: Test for VMSTATE_STRUCT_VARRAY_POINTER_INT32, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 123/124] vmstate: Test for VMSTATE_ARRAY_OF_POINTER_TO_STRUCT, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 124/124] vmstate: Test for VMSTATE_ARRAY_OF_POINTER, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 114/124] vmstate: Remove unused VMSTATE_STRUCT_POINTER_TEST, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 110/124] vmstate: Test for VMSTATE_VARRAY_INT32, Juan Quintela, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Peter Maydell, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Juan Quintela, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive),
Peter Maydell <=
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Juan Quintela, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Peter Maydell, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Paolo Bonzini, 2014/04/21
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Dr. David Alan Gilbert, 2014/04/22
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Paolo Bonzini, 2014/04/27
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Michael S. Tsirkin, 2014/04/27
- Re: [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Juan Quintela, 2014/04/21
[Qemu-devel] [PATCH 115/124] vmstate: Test for VMSTATE_STRUCT_POINTER, Juan Quintela, 2014/04/21
[Qemu-devel] [PATCH 071/124] vmstate: Remove version field from VMSTATE_STRUCT_VARRAY_UINT32, Juan Quintela, 2014/04/21
[Qemu-devel] [PATCH 116/124] vmstate: Test VMSTATE_STRUCT_ARRAY, Juan Quintela, 2014/04/21