qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm)
Date: Mon, 21 Apr 2014 17:18:53 +0100

On 21 April 2014 15:39, Juan Quintela <address@hidden> wrote:
> After previous Peter patch, they are redundant.  This way we don't asign them
> except when needed.  Once there, there were lots of case where the ".fields"
> indentation was wrong:
>
>      .fields = (VMStateField []) {
> and
>      .fields =      (VMStateField []) {
>
> Change all the combinations to:
>
>      .fields = (VMStateField[]){
>
> The biggest problem (appart of aesthetics) was that checkpatch complained
> when we copy&pasted the code from one place to another.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---

Reviewed-by: Peter Maydell <address@hidden>

I'll hold this to apply to target-arm.next when you've got the dependent
patch into master.

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]