[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm) |
Date: |
Mon, 21 Apr 2014 17:18:53 +0100 |
On 21 April 2014 15:39, Juan Quintela <address@hidden> wrote:
> After previous Peter patch, they are redundant. This way we don't asign them
> except when needed. Once there, there were lots of case where the ".fields"
> indentation was wrong:
>
> .fields = (VMStateField []) {
> and
> .fields = (VMStateField []) {
>
> Change all the combinations to:
>
> .fields = (VMStateField[]){
>
> The biggest problem (appart of aesthetics) was that checkpatch complained
> when we copy&pasted the code from one place to another.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
Reviewed-by: Peter Maydell <address@hidden>
I'll hold this to apply to target-arm.next when you've got the dependent
patch into master.
thanks
-- PMM
- [Qemu-devel] [PATCH v2 000/124] VMState Simplification (Massive), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 001/124] savevm: Ignore minimum_version_id_old if there is no load_state_old, Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm), Juan Quintela, 2014/04/21
- Re: [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm),
Peter Maydell <=
- [Qemu-devel] [PATCH 002/124] savevm: Remove all the unneded version_minimum_id_old (usb), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 005/124] savevm: Remove all the unneded version_minimum_id_old (x86), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 003/124] savevm: Remove all the unneded version_minimum_id_old (ppc), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 006/124] savevm: Remove all the unneded version_minimum_id_old (rest), Juan Quintela, 2014/04/21
- [Qemu-devel] [PATCH 007/124] vmstate: Return error in case of error, Juan Quintela, 2014/04/21