[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vmdk: Fix %d and %lld to PRI* in format strings
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH] vmdk: Fix %d and %lld to PRI* in format strings |
Date: |
Thu, 17 Apr 2014 17:35:26 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 04/17 10:28, Kevin Wolf wrote:
> Am 17.04.2014 um 05:34 hat Fam Zheng geschrieben:
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > block/vmdk.c | 13 +++++++------
> > 1 file changed, 7 insertions(+), 6 deletions(-)
>
> Thanks, applied to the block branch.
>
> > @@ -1720,7 +1721,7 @@ static int vmdk_create(const char *filename,
> > QEMUOptionParameter *options,
> > "\n"
> > "ddb.virtualHWVersion = \"%d\"\n"
> > "ddb.geometry.cylinders = \"%" PRId64 "\"\n"
> > - "ddb.geometry.heads = \"%d\"\n"
> > + "ddb.geometry.heads = \"%" PRIu32 "\"\n"
> > "ddb.geometry.sectors = \"63\"\n"
> > "ddb.adapterType = \"%s\"\n";
>
> The same template also has:
>
> "parentCID=%x\n"
>
> This should be changed to PRIx32 in a follow-up patch.
>
Thanks for noticing this, I missed it because I only looked for "%.*d"...
Will send a follow-up patch.
Fam