Re: [Qemu-devel] [PATCH 1/7] megasas: Enable MSI-X support

[Hannes Reinecke]

On 04/16/2014 01:43 PM, Alexander Graf wrote:
> 
> On 16.04.14 09:16, Hannes Reinecke wrote:
>> MSI-X support has been fixed in qemu, so we can enable it again.
>>
>> Signed-off-by: Hannes Reinecke <address@hidden>
>> ---
>>   hw/scsi/megasas.c | 20 ++++++--------------
>>   1 file changed, 6 insertions(+), 14 deletions(-)
>>
>> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
>> index e6e1ffd..496bab8 100644
>> --- a/hw/scsi/megasas.c
>> +++ b/hw/scsi/megasas.c
>> @@ -29,7 +29,7 @@
>>     #include "mfi.h"
>>   -#define MEGASAS_VERSION "1.70"
>> +#define MEGASAS_VERSION "1.71"
> 
> What happens when I create a VM on 2.0 and then run it with 2.1?
> Will the VM see a difference?
> 
The only difference you'll see is a different PCI configuration.
Other than that the behaviour will be identical.

For compatible behaviour you'd need to set 'use_msix=false' in the
megasas configuration.

If this really is an issue I can re-sent the patch with defaulting
back to 'false'.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                   zSeries & Storage
address@hidden                        +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)