[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-arm: A64: fix unallocated test of scalar
From: |
Claudio Fontana |
Subject: |
Re: [Qemu-devel] [PATCH] target-arm: A64: fix unallocated test of scalar SQXTUN |
Date: |
Wed, 16 Apr 2014 13:35:17 +0200 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 |
On 16.04.2014 13:29, Alex Bennée wrote:
> The test for the U bit was incorrectly inverted in the scalar case of SQXTUN.
> This doesn't affect the vector case as the U bit is used to select XTN(2).
>
> Reported-by: Hao Liu <address@hidden>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
> target-arm/translate-a64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index a74128c..0adffbb 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -7553,7 +7553,7 @@ static void disas_simd_scalar_two_reg_misc(DisasContext
> *s, uint32_t insn)
> }
> break;
> case 0x12: /* SQXTUN */
> - if (u) {
> + if (!u) {
> unallocated_encoding(s);
> return;
> }
>
Reviewed-by: Claudio Fontana <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |