[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU |
Date: |
Wed, 16 Apr 2014 08:41:51 +0200 |
Hi,
> Add "void smbios_get_tables()" as a separate function to generate the
> entry point and aggregate smbios table, and then:
>
> if "machine_type < 2.1" then
>
> insert smbios_get_table() into fw_cfg (compat mode)
>
> else
>
> insert smbios_get_tables() blob + entry point (new hotness)
>
> fi
I mean this:
insert smbios_get_table() into fw_cfg (compat mode)
if (machine_type >= 2.1)
insert smbios_get_tables() blob + entry point (new hotness)
But maybe your variant is better as it encourages the move to the new
interfaces on the firmware side. And if we merge it early in the 2.1
cycle there is quite some time for the firmware to sort things.
> I guess both compat and new smbios_get_table[s] can use the same
> default fields set via the command line.
Yes.
> The remaining issue is how to handle "-smbios file=<foo>" blobs; maybe
> smbios_set_defaults() can be used to set the version, and then the
> command line parser (smbios_entry_add()) would know which kind of table
> to insert the blob into, compat or aggregate ?
>
> That being said, how do I even tell the difference between pre- and
> post- 2.1 machine types ? Would that be in pc.c, or pc_[q35|piix].c ?
Global variable, simliar to smbios_type1_defaults. machine type init
code will set it accordingly. smbios code just does "if
(smbios_generate_tables) { ... }" (or however we name this).
cheers,
Gerd
- [Qemu-devel] [QEMU v6 PATCH 08/17] SMBIOS: Build full type 4 tables, (continued)
- [Qemu-devel] [QEMU v6 PATCH 08/17] SMBIOS: Build full type 4 tables, Gabriel L. Somlo, 2014/04/14
- [Qemu-devel] [QEMU v6 PATCH 11/17] SMBIOS: Generate aggregate smbios tables, including entry point, Gabriel L. Somlo, 2014/04/14
- [Qemu-devel] [QEMU v6 PATCH 12/17] SMBIOS: Remove SeaBIOS compatibility quirks, Gabriel L. Somlo, 2014/04/14
- [Qemu-devel] [QEMU v6 PATCH 13/17] SMBIOS: Stop including type 20 tables, Gabriel L. Somlo, 2014/04/14
- [Qemu-devel] [QEMU v6 PATCH 14/17] SMBIOS: Use e820 memory map to generate type 19 tables, Gabriel L. Somlo, 2014/04/14
- [Qemu-devel] [QEMU v6 PATCH 15/17] SMBIOS: Update type 3 definition to smbios spec v2.7, Gabriel L. Somlo, 2014/04/14
- [Qemu-devel] [QEMU v6 PATCH 16/17] SMBIOS: Update type 4 definition to smbios spec v2.6, Gabriel L. Somlo, 2014/04/14
- [Qemu-devel] [QEMU v6 PATCH 17/17] SMBIOS: Update memory table types (16, 17, and 19) to smbios spec v2.8, Gabriel L. Somlo, 2014/04/14
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Gerd Hoffmann, 2014/04/15
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Gabriel L. Somlo, 2014/04/15
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU,
Gerd Hoffmann <=
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Gabriel L. Somlo, 2014/04/16
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Gerd Hoffmann, 2014/04/17
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Gabriel L. Somlo, 2014/04/17
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Gerd Hoffmann, 2014/04/22
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Gabriel L. Somlo, 2014/04/22
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Gerd Hoffmann, 2014/04/22
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Markus Armbruster, 2014/04/22
- Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Gabriel L. Somlo, 2014/04/22
Re: [Qemu-devel] [QEMU v6 PATCH 00/17] SMBIOS: build full tables in QEMU, Kevin O'Connor, 2014/04/15