Re: [Qemu-devel] [PATCH v4 1/4] util/fifo: Generalise naming scheme

[Beniamino Galvani]

On Mon, Apr 14, 2014 at 08:18:20PM -0700, Peter Crosthwaite wrote:
> Generalise the names of the FIFO API to not include the "8".
> 
> The exception is the push/pop functions for which we:
> 
> s/fifo8_pop/fifo_pop8
> s/fifo8_push/fifo_push8
> 
> This prepares support for generalising FIFO support to more integer
> widths. Most APIs will just share name and implementation. The push
> and pop ones we change, as the "fifo8" type no longer exists, and
> changing to to fifo_xxxNN will be more consistent with other APIs
> that have different bit width variants.
> 
> Signed-off-by: Peter Crosthwaite <address@hidden>

Reviewed-by: Beniamino Galvani <address@hidden>