Re: [Qemu-devel] [PATCH 09/35] qdev: expose DeviceState.hotplugged field as a property

[Andreas Färber]

Am 04.04.2014 15:36, schrieb Igor Mammedov:
> so that managment could detect via QOM interface if device was

"management"

> hotplugged
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  hw/core/qdev.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 50bb8f5..a278380 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -826,6 +826,20 @@ static bool device_get_hotpluggable(Object *obj, Error 
> **err)
>                                  dev->parent_bus->allow_hotplug);
>  }
>  
> +static bool device_get_hotplugged(Object *obj, Error **err)
> +{
> +    DeviceState *dev = DEVICE(obj);
> +
> +    return dev->hotplugged;
> +}
> +
> +static void device_set_hotplugged(Object *obj, bool value, Error **err)
> +{
> +    DeviceState *dev = DEVICE(obj);
> +
> +    dev->hotplugged = value;
> +}

What is the use case of setting this from management side?

Otherwise looks good.

Regards,
Andreas

> +
>  static void device_initfn(Object *obj)
>  {
>      DeviceState *dev = DEVICE(obj);
> @@ -844,6 +858,9 @@ static void device_initfn(Object *obj)
>                               device_get_realized, device_set_realized, NULL);
>      object_property_add_bool(obj, "hotpluggable",
>                               device_get_hotpluggable, NULL, NULL);
> +    object_property_add_bool(obj, "hotplugged",
> +                             device_get_hotplugged, device_set_hotplugged,
> +                             &error_abort);
>  
>      class = object_get_class(OBJECT(dev));
>      do {
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg