Re: [Qemu-devel] [PATCH for-2.0] qom: Fix crash with qom-list and link properties

[Andreas Färber]

Am 11.04.2014 19:05, schrieb Cole Robinson:
> On 04/11/2014 12:57 PM, Andreas Färber wrote:
>> Am 10.04.2014 20:47, schrieb Cole Robinson:
>>> Commit 9561fda8d90e176bef598ba87c42a1bd6ad03ef7 changed the type of
>>> 'opaque' for link properties, but missed updating this call site.
>>> Reproducer:
>>>
>>> ./x86_64-softmmu/qemu-system-x86_64 -qmp unix:./qmp.sock,server &
>>> ./scripts/qmp/qmp-shell ./qmp.sock
>>> (QEMU) qom-list path=//machine/i440fx/pci.0/child[2]
>>
>> I would much prefer if we could give the path as just
>> path=/machine/i440fx/pci.0/child[2] (without double slash). Peter can
>> you improve when applying?
>>
>>>
>>> Reported-by: Marcin Gibuła <address@hidden>
>>> Signed-off-by: Cole Robinson <address@hidden>
>>> ---
>>>  qom/object.c | 3 ++-
>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> Reviewed-by: Andreas Färber <address@hidden>
>>
>> I would like to remark that specifically for regression-testing link<>
>> properties I had extended qom-test, and it succeeds currently. So Cole,
>> if you have any suggestion on how to extend it to catch this regression
>> that would be welcome.
>>
> 
> I haven't looked closely at tests/, I see *qmp*.c files, but is there
> infrastructure for running qmp commands? If so we could turn the above
> reproducer into a test case.

Please see the mentioned tests/qom-test.c, it is already doing qom-list
+ qom-get for all properties - therefore wondering why we didn't catch this.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg