[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 1/4] qapi: [trivial] Break long command lines
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v8 1/4] qapi: [trivial] Break long command lines |
|
Date: |
Fri, 11 Apr 2014 09:42:00 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/02/2014 09:16 AM, Lluís Vilanova wrote:
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> Makefile | 24 ++++++++++++++++++------
> tests/Makefile | 20 ++++++++++++++++----
> 2 files changed, 34 insertions(+), 10 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
> + $(call quiet-command, PYTHONPATH=$(SRC_PATH)/scripts \
> + $(PYTHON) $(SRC_PATH)/tests/qapi-schema/test-qapi.py \
> + <$^ \
> + >$*.test.out \
> + 2>$*.test.err; \
I probably would have merged these three lines, but that's cosmetic and
doesn't affect my review.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature