[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames |
Date: |
Thu, 10 Apr 2014 15:53:57 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, 04/09 22:41, Jeff Cody wrote:
> The _rm_test_img() function in common.rc did not quote the image
> file, which left droppings in the scratch directory (and performed
> a potentially unsafe rm -f).
>
> This adds the necessary quotes.
>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
> tests/qemu-iotests/common.rc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 7f00883..195c564 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -178,10 +178,10 @@ _rm_test_img()
> local img=$1
Since we are quoting $img, should we quote $1 as well?
Fam
> if [ "$IMGFMT" = "vmdk" ]; then
> # Remove all the extents for vmdk
> - $QEMU_IMG info $img 2>/dev/null | grep 'filename:' | cut -f 2 -d: \
> + "$QEMU_IMG" info "$img" 2>/dev/null | grep 'filename:' | cut -f 2
> -d: \
> | xargs -I {} rm -f "{}"
> fi
> - rm -f $img
> + rm -f "$img"
> }
>
> _cleanup_test_img()
> --
> 1.8.3.1
>
>
- [Qemu-devel] [PATCH v2 1/5] block: qemu-iotests - add common.qemu, for bash-controlled qemu tests, (continued)
- [Qemu-devel] [PATCH v2 1/5] block: qemu-iotests - add common.qemu, for bash-controlled qemu tests, Jeff Cody, 2014/04/09
- [Qemu-devel] [PATCH v2 3/5] block: qemu-iotests - test for live migration, Jeff Cody, 2014/04/09
- [Qemu-devel] [PATCH v2 2/5] block: qemu-iotests - update 085 to use common.qemu, Jeff Cody, 2014/04/09
- [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames, Jeff Cody, 2014/04/09
- Re: [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames,
Fam Zheng <=
- Re: [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames, Jeff Cody, 2014/04/10
- Re: [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames, Eric Blake, 2014/04/10
- Re: [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames, Eric Blake, 2014/04/10
- Re: [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames, Jeff Cody, 2014/04/10
- Re: [Qemu-devel] [PATCH v2 4/5] block: qemu-iotests - fix image cleanup when using spaced pathnames, Fam Zheng, 2014/04/10
[Qemu-devel] [PATCH v2 5/5] block: qemu-iotests: make test 019 and 086 work with spaced pathnames, Jeff Cody, 2014/04/09