[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL for-2.0] dsdt: tweak ACPI ID for hotplug resource
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PULL for-2.0] dsdt: tweak ACPI ID for hotplug resource device |
Date: |
Wed, 9 Apr 2014 09:54:06 +0200 |
On Tue, 8 Apr 2014 15:24:18 +0300
"Michael S. Tsirkin" <address@hidden> wrote:
> ACPI0004 seems too new:
> Windows XP complains about an unrecognized device.
> This is a regression since 1.7.
> Use PNP0A06 instead - Generic Container Device.
>
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> Reviewed-By: Igor Mammedov <address@hidden>
> ---
> hw/i386/acpi-dsdt-cpu-hotplug.dsl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> index dee4843..34aab5a 100644
> --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl
> @@ -93,7 +93,7 @@ Scope(\_SB) {
> }
>
> Device(CPU_HOTPLUG_RESOURCE_DEVICE) {
> - Name(_HID, "ACPI0004")
> + Name(_HID, EisaId("PNP0A06"))
>
> Name(_CRS, ResourceTemplate() {
> IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS_LEN)
There is a need to update test cases with new DSDTs, since it breaks them.