[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] monitor: Add pmemload command
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] monitor: Add pmemload command |
Date: |
Tue, 08 Apr 2014 12:31:02 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 |
On 04/08/2014 11:17 AM, Baojun Wang wrote:
> Hi list,
>
> Is it possible to add a monitor command ``pmemload'' as pmemsave?
> I found this could be useful to have qemu-softmmu as a cross debugger
> (launch with -s -S command line option), then if we can have a command to
> load guest physical memory, we can use cross gdb to do some target debug
> which gdb cannot do directly.
>
> Attachment is a trivial patch add pmemload monitor command.
We prefer patches sent inline via 'git send-email', as they are easier
to reply to.
> +++ b/qapi-schema.json
> @@ -1708,6 +1708,26 @@
> 'data': {'val': 'int', 'size': 'int', 'filename': 'str'} }
>
> ##
> +# @pmemload:
> +#
> +# Load a portion of guest physical memory from a file.
> +#
> +# @val: the physical address of the guest to start from
> +#
> +# @size: the size of memory region to save
s/save/load/ ?
> +#
> +# @filename: the file to load the memory from as binary data
> +#
> +# Returns: Nothing on success
> +#
> +# Since: 2.0
You've missed 2.0; at the earliest, this would be 2.1.
> +#
> +# Notes: Errors were not reliably returned until 1.1
This note is bogus copy and paste - since the command is new to 2.1,
there is no unreliable error handling in 1.1.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature