[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 1/4] gtk: Use gtk generic event signal instead of
From: |
Takashi Iwai |
Subject: |
[Qemu-devel] [PATCH v3 1/4] gtk: Use gtk generic event signal instead of motion-notify-event |
Date: |
Fri, 4 Apr 2014 12:41:21 +0200 |
The GDK motion-notify-event isn't generated when the pointer goes out
of the target window even if the pointer is grabbed, which essentially
means to lose the pointer tracking in gtk-ui.
Meanwhile the generic "event" signal is sent when the pointer is
grabbed, so we can use this and pick the motion notify events manually
there instead.
Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587
Tested-by: Cole Robinson <address@hidden>
Reviewed-by: Cole Robinson <address@hidden>
Signed-off-by: Takashi Iwai <address@hidden>
---
ui/gtk.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index f056e4034b3e..c9f6d24eeb1a 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -765,6 +765,14 @@ static gboolean gd_key_event(GtkWidget *widget,
GdkEventKey *key, void *opaque)
return TRUE;
}
+static gboolean gd_event(GtkWidget *widget, GdkEvent *event, void *opaque)
+{
+ if (event->type == GDK_MOTION_NOTIFY) {
+ return gd_motion_event(widget, &event->motion, opaque);
+ }
+ return FALSE;
+}
+
/** Window Menu Actions **/
static void gd_menu_pause(GtkMenuItem *item, void *opaque)
@@ -1267,8 +1275,8 @@ static void gd_connect_signals(GtkDisplayState *s)
g_signal_connect(s->drawing_area, "expose-event",
G_CALLBACK(gd_expose_event), s);
#endif
- g_signal_connect(s->drawing_area, "motion-notify-event",
- G_CALLBACK(gd_motion_event), s);
+ g_signal_connect(s->drawing_area, "event",
+ G_CALLBACK(gd_event), s);
g_signal_connect(s->drawing_area, "button-press-event",
G_CALLBACK(gd_button_event), s);
g_signal_connect(s->drawing_area, "button-release-event",
--
1.9.1
- [Qemu-devel] [PATCH v3 0/4] Fix relative pointer tracking on Gtk UI, Takashi Iwai, 2014/04/04
- [Qemu-devel] [PATCH v3 4/4] gtk: Add "Grab On Click" option, Takashi Iwai, 2014/04/04
- [Qemu-devel] [PATCH v3 3/4] gtk: Remember the last grabbed pointer position, Takashi Iwai, 2014/04/04
- [Qemu-devel] [PATCH v3 2/4] gtk: Fix the relative pointer tracking mode, Takashi Iwai, 2014/04/04
- [Qemu-devel] [PATCH v3 1/4] gtk: Use gtk generic event signal instead of motion-notify-event,
Takashi Iwai <=
- Re: [Qemu-devel] [PATCH v3 0/4] Fix relative pointer tracking on Gtk UI, Brian Jackson, 2014/04/04
- Re: [Qemu-devel] [PATCH v3 0/4] Fix relative pointer tracking on Gtk UI, Michael S. Tsirkin, 2014/04/06