qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2 4/5] hw/ppc: remove QEMUMachine indirection


From: Marcel Apfelbaum
Subject: Re: [Qemu-devel] [PATCH V2 4/5] hw/ppc: remove QEMUMachine indirection
Date: Thu, 03 Apr 2014 20:46:46 +0300

On Thu, 2014-04-03 at 19:25 +0200, Andreas Färber wrote:
> Am 31.03.2014 11:26, schrieb Marcel Apfelbaum:
> > No need for QEMUMachine anymore because
> > its fields are passed to MachineClass.
> 
> QEMUMachineInitArgs still has a QEMUMachine field that now becomes NULL?
No... 
It is properly initiated right before the machine init: (No changes made)


   QEMUMachineInitArgs args = { .machine = machine, 
                                .ram_size = ram_size, 
                                .boot_order = boot_order, 
                                .kernel_filename = kernel_filename, 
                                .kernel_cmdline = kernel_cmdline, 
                                .initrd_filename = initrd_filename, 
                                .cpu_model = cpu_model }; 
   
   current_machine->init_args = args; 
   machine->init(&current_machine->init_args);

I plan to get rid of this too, but it touches a lot of files,
I am looking for a clean way to get rid of it.

Thanks,
Marcel

> 
> Andreas
> 






reply via email to

[Prev in Thread] Current Thread [Next in Thread]