[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.0? 2/2] cpu-exec: Unlock tb_lock if we lon
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.0? 2/2] cpu-exec: Unlock tb_lock if we longjmp out of code generation |
|
Date: |
Thu, 3 Apr 2014 17:53:54 +0100 |
On 3 April 2014 17:51, Richard Henderson <address@hidden> wrote:
> On 04/03/2014 09:45 AM, Peter Maydell wrote:
>> + if (have_tb_lock) {
>> + spin_unlock(&tcg_ctx.tb_ctx.tb_lock);
>> + }
>
> It ought not matter, since we ought to exit the loop on the
> next round, but i have a strong preference for resetting
> have_tb_lock here.
Absolutely -- dumb oversight on my part.
thanks
-- PMM
[Qemu-devel] [PATCH for-2.0? 1/2] page_check_range: don't bail out early after unprotecting page, Peter Maydell, 2014/04/03