qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] dma-helpers: Initialize DMAAIOCB in_cancel


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 1/2] dma-helpers: Initialize DMAAIOCB in_cancel flag
Date: Thu, 3 Apr 2014 15:28:56 +0100

On 28 March 2014 14:22, Peter Maydell <address@hidden> wrote:
> Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get()
> does not return zero-initialized memory. Spotted by the clang sanitizer
> (which complained when the value loaded in dma_complete() was not valid
> for a bool type); this might have resulted in leaking the AIO block.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>
>  dma-helpers.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/dma-helpers.c b/dma-helpers.c
> index c9620a5..5f421e9 100644
> --- a/dma-helpers.c
> +++ b/dma-helpers.c
> @@ -213,6 +213,7 @@ BlockDriverAIOCB *dma_bdrv_io(
>      dbs->sg_cur_index = 0;
>      dbs->sg_cur_byte = 0;
>      dbs->dir = dir;
> +    dbs->in_cancel = false;
>      dbs->io_func = io_func;
>      dbs->bh = NULL;
>      qemu_iovec_init(&dbs->iov, sg->nsg);
> --
> 1.9.0

Ping, or do we think this isn't worthwhile for 2.0?

(I guess I should have stuck a for-2.0 in the subject.)

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]