qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [RFC] tests: Add ivshmem qtest
Date: Thu, 3 Apr 2014 10:46:24 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Wed, Apr 02, 2014 at 04:57:48PM +0200, Andreas Färber wrote:
> +int main(int argc, char **argv)
> +{
> +    QTestState *s1, *s2;
> +    char *cmd;
> +    int ret;
> +
> +    g_test_init(&argc, &argv, NULL);
> +    qtest_add_func("/ivshmem/nop", nop);
> +
> +    cmd = g_strdup_printf("-device ivshmem,shm=%s,size=1M", "qtest");

This test leaks the "qtest" shm object that gets created by the first
QEMU process.  The name is constant so two instances of the test cannot
run in parallel on the same machine (the objects go in /dev/shm).

The name should be unique and we should clean up in both success and
failure (abort(3)) cases.

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]