[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.0] iscsi: ignore flushes on scsi-generic d
From: |
Peter Lieven |
Subject: |
Re: [Qemu-devel] [PATCH for-2.0] iscsi: ignore flushes on scsi-generic devices |
Date: |
Wed, 02 Apr 2014 22:33:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 |
Am 02.04.2014 15:05, schrieb Paolo Bonzini:
> Non-block SCSI devices do not support flushing, but we may still send
> them requests via bdrv_flush_all. Just ignore them.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block/iscsi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index 0d15b4d..00316af 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -417,6 +417,10 @@ static int coroutine_fn iscsi_co_flush(BlockDriverState
> *bs)
> IscsiLun *iscsilun = bs->opaque;
> struct IscsiTask iTask;
>
> + if (bs->sg) {
> + return 0;
> + }
> +
> iscsi_co_init_iscsitask(iscsilun, &iTask);
>
> retry:
Reviewed-by: Peter Lieven <address@hidden>