[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/7] hw/net/stellaris_enet: Rewrite tx fifo h
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/7] hw/net/stellaris_enet: Rewrite tx fifo handling code |
Date: |
Wed, 2 Apr 2014 16:28:43 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Peter Maydell (address@hidden) wrote:
> The datasheet is clear that the frame length written to the DATA
> register is actually stored in the TX FIFO; this means we don't
> need to keep both tx_frame_len and tx_fifo_len state separately.
>
> Signed-off-by: Peter Maydell <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> - register_savevm(dev, "stellaris_enet", -1, 1,
> + register_savevm(dev, "stellaris_enet", -1, 2,
> stellaris_enet_save, stellaris_enet_load, s);
> return 0;
Note that as well as inc'ing that you would have to change the
if (version_id != 1)
in stellaris_enet_load (if you weren't about to scrap the load/save
code anyway).
Dave
> }
> --
> 1.9.0
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v2 0/7] stellaris_enet: overhaul tx/rx, convert to vmstate, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH v2 7/7] hw/net/stellaris_enet: Convert to vmstate, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH v2 4/7] hw/net/stellaris_enet: Correctly implement the TR and THR registers, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH v2 3/7] hw/net/stellaris_enet: Rewrite tx fifo handling code, Peter Maydell, 2014/04/01
- Re: [Qemu-devel] [PATCH v2 3/7] hw/net/stellaris_enet: Rewrite tx fifo handling code,
Dr. David Alan Gilbert <=
- [Qemu-devel] [PATCH v2 6/7] hw/net/stellaris_enet: Get rid of rx_fifo pointer, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH v2 1/7] hw/net/stellaris_enet: Restructure tx_fifo code to avoid buffer overrun, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH v2 5/7] hw/net/stellaris_enet: Fix debug format strings, Peter Maydell, 2014/04/01
- [Qemu-devel] [PATCH v2 2/7] hw/net/stellaris_enet: Correct handling of packet padding, Peter Maydell, 2014/04/01
- Re: [Qemu-devel] [PATCH v2 0/7] stellaris_enet: overhaul tx/rx, convert to vmstate, Michael S. Tsirkin, 2014/04/28