[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6] net: L2TPv3 transport
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v6] net: L2TPv3 transport |
Date: |
Thu, 27 Mar 2014 07:12:32 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/26/2014 05:08 AM, address@hidden wrote:
> From: Anton Ivanov <address@hidden>
>
> This transport allows to connect a QEMU nic to a static Ethernet
> over L2TPv3 tunnel. The transport supports all options present
> in the Linux kernel implementation. It allows QEMU to connect
> to any Linux host running kernel 3.3+, most routers and network
> devices as well as other QEMU instances.
>
> Signed-off-by: Anton Ivanov <address@hidden>
> ---
> #
> # Since 1.2
> -##
> +#
> +# Added in 2.1 - l2tpv3
> +#
> { 'union': 'NetClientOptions',
Minor nit - you lost the ## end-of-comment line. Also, see how QKeyCode
mentioned added values:
# Since: 1.3.0
#
# 'unmapped' and 'pause' since 2.0
##
We haven't done this sort of addition much to date, but it can't hurt to
use a consistent style when doing so.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature