[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filena

From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH 4/6] monitor: Remove unused monitor_print_filename
Date: Wed, 26 Mar 2014 14:46:21 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux)

Andreas Färber <address@hidden> writes:

> Am 24.03.2014 14:09, schrieb Luiz Capitulino:
>> On Sat, 22 Mar 2014 21:06:41 +0100
>> Andreas Färber <address@hidden> wrote:
>>> Am 12.03.2014 00:15, schrieb Cole Robinson:
>>>> Cc: Luiz Capitulino <address@hidden>
>>>> Cc: Markus Armbruster <address@hidden>
>>>> Signed-off-by: Cole Robinson <address@hidden>
>>> Given that it even had its own stub file, the commit message should
>>> please explain why it is no longer needed and thus okay to drop.
>> Because it's unused?
> That's no real answer. Why did it need to be escaped before the commit
> Cole pointed to and now no longer is?

Valid question, but it applies to the commits that dropped uses, not to
Cole's patch.

The function goes back to 2006, commit fef3074 "Escape filname printout
properly".  This made "info block" print some but not all funny
characters in filenames more legibly.  Dropped in Kevin's commit fbe2e26
"hmp: Make "info block" output more readable" from last June.  Could be
regarded as regression.  Not sure we care.

A second use was introduced a couple of months later, in commit a9ce859
"info vnc command".  Reason for escaping isn't obvious to me.  Dropped
in commit 1ff7df1 "Enhance 'info vnc' monitor output", which prints
something else entirely.

> My point was that someone went throught the hassle of creating a stub
> file just for this functionality, so it's not some random unused
> function in some file. (But I'm not particularly attached to it, just
> cautioning about removing too much in this non-verbose way, making it
> hard to follow for outsiders.)

Sounds like you'd like a more vebose commit message.  What information
would you like to see?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]