[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v23 09/32] add qemu_opts_append to repalce appen
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v23 09/32] add qemu_opts_append to repalce append_option_parameters |
Date: |
Tue, 25 Mar 2014 15:40:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 03/21/2014 04:12 AM, Chunyan Liu wrote:
s/repalce/replace/ in subject
Also, your overall series could probably use subject lines with a prefix
that makes it obvious they are related to a common category; maybe "opts: ".
> For later merge .create_opts of drv and proto_drv in qemu-img commands.
>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
> +
> +/* Realloc dst option list and append options either from an option list
> (list)
> + * or an QEMUOptionParameter (param) to it. dst could be NULL or a malloced
> list.
s/an QEMU/a QEMU/
> + * FIXME: will remove QEMUOptionParameter after all drivers switch to
> QemuOpts.
> + */
> +QemuOptsList *qemu_opts_append(QemuOptsList *dst,
> + QemuOptsList *list,
> + QEMUOptionParameter *param)
> +{
> + size_t num_opts, num_dst_opts;
> + QemuOptsList *tmp_list = NULL;
> + QemuOptDesc *desc;
> + bool need_init = false;
> +
> + assert(!(list && param));
> + if (!param &&!list) {
Space after &&
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v23 10/32] check NULL input for qemu_opts_del, (continued)
- [Qemu-devel] [PATCH v23 11/32] qemu_opts_print: change fprintf stderr to printf, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 12/32] qcow2.c: remove 'assigned' check in amend, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 14/32] vvfat.c: handle cross_driver's create_options and create_opts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 13/32] change block layer to support both QemuOpts and QEMUOptionParamter, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 09/32] add qemu_opts_append to repalce append_option_parameters, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 15/32] cow.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 17/32] iscsi.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 19/32] qcow2.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 16/32] gluster.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 18/32] qcow.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 20/32] qed.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 21/32] raw-posix.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 23/32] raw_bsd.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 24/32] rbd.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21
- [Qemu-devel] [PATCH v23 28/32] vhdx.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/03/21