[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 07/26] cow: migrate cow driver QemuOptionParameter u
From: |
Leandro Dorileo |
Subject: |
[Qemu-devel] [PATCH 07/26] cow: migrate cow driver QemuOptionParameter usage |
Date: |
Thu, 20 Mar 2014 21:13:14 -0300 |
Do the directly migration from QemuOptionParameter to QemuOpts on
cow block driver.
Signed-off-by: Leandro Dorileo <address@hidden>
---
block/cow.c | 44 ++++++++++++++++++++++----------------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/block/cow.c b/block/cow.c
index 30deb88..811f7f7 100644
--- a/block/cow.c
+++ b/block/cow.c
@@ -324,8 +324,7 @@ static void cow_close(BlockDriverState *bs)
{
}
-static int cow_create(const char *filename, QEMUOptionParameter *options,
- Error **errp)
+static int cow_create(const char *filename, QemuOpts *options, Error **errp)
{
struct cow_header_v2 cow_header;
struct stat st;
@@ -335,16 +334,13 @@ static int cow_create(const char *filename,
QEMUOptionParameter *options,
int ret;
BlockDriverState *cow_bs;
- /* Read out options */
- while (options && options->name) {
- if (!strcmp(options->name, BLOCK_OPT_SIZE)) {
- image_sectors = options->value.n / 512;
- } else if (!strcmp(options->name, BLOCK_OPT_BACKING_FILE)) {
- image_filename = options->value.s;
- }
- options++;
+ image_sectors = qemu_opt_get_size(options, BLOCK_OPT_SIZE, 0);
+ if (image_sectors) {
+ image_sectors = image_sectors / 512;
}
+ image_filename = qemu_opt_get(options, BLOCK_OPT_BACKING_FILE);
+
ret = bdrv_create_file(filename, options, &local_err);
if (ret < 0) {
error_propagate(errp, local_err);
@@ -393,18 +389,22 @@ exit:
return ret;
}
-static QEMUOptionParameter cow_create_options[] = {
- {
- .name = BLOCK_OPT_SIZE,
- .type = OPT_SIZE,
- .help = "Virtual disk size"
- },
- {
- .name = BLOCK_OPT_BACKING_FILE,
- .type = OPT_STRING,
- .help = "File name of a base image"
+static QemuOptsList cow_create_options = {
+ .name = "cow_create_options",
+ .head = QTAILQ_HEAD_INITIALIZER(cow_create_options.head),
+ .desc = {
+ {
+ .name = BLOCK_OPT_SIZE,
+ .type = QEMU_OPT_SIZE,
+ .help = "Virtual disk size"
+ },
+ {
+ .name = BLOCK_OPT_BACKING_FILE,
+ .type = QEMU_OPT_STRING,
+ .help = "File name of a base image"
+ },
+ { NULL }
},
- { NULL }
};
static BlockDriver bdrv_cow = {
@@ -421,7 +421,7 @@ static BlockDriver bdrv_cow = {
.bdrv_write = cow_co_write,
.bdrv_co_get_block_status = cow_co_get_block_status,
- .create_options = cow_create_options,
+ .create_options = &cow_create_options,
};
static void bdrv_cow_init(void)
--
1.9.0
- [Qemu-devel] [PATCH 00/26] QemuOptionParameter -> QemuOpts migration, Leandro Dorileo, 2014/03/20
- [Qemu-devel] [PATCH 01/26] qapi: output def_value_str when query command line options, Leandro Dorileo, 2014/03/20
- [Qemu-devel] [PATCH 02/26] add def_value_str to QemuOptDesc, Leandro Dorileo, 2014/03/20
- [Qemu-devel] [PATCH 03/26] QemuOpt: improve default value, Leandro Dorileo, 2014/03/20
- [Qemu-devel] [PATCH 04/26] QemuOpt: introduce qemu_opts_append(), Leandro Dorileo, 2014/03/20
- [Qemu-devel] [PATCH 05/26] QemuOpt: add qemu_opt_print_help(), Leandro Dorileo, 2014/03/20
- [Qemu-devel] [PATCH 06/26] block: migrate block later QemuOptionParameter, Leandro Dorileo, 2014/03/20
- [Qemu-devel] [PATCH 07/26] cow: migrate cow driver QemuOptionParameter usage,
Leandro Dorileo <=
- [Qemu-devel] [PATCH 08/26] gluster: migrate gluster driver QemuOptionParameter usage, Leandro Dorileo, 2014/03/20
- [Qemu-devel] [PATCH 09/26] iscsi: migrate iscsi driver QemuOptionParameter usage, Leandro Dorileo, 2014/03/20
[Qemu-devel] [PATCH 10/26] nfs: migrate nfs driver QemuOptionParameter usage, Leandro Dorileo, 2014/03/20
[Qemu-devel] [PATCH 11/26] qcow: migrate qcow driver QemuOptionParameter usage, Leandro Dorileo, 2014/03/20
[Qemu-devel] [PATCH 12/26] qcow2: migrate qcow2 driver QemuOptionParameter usage, Leandro Dorileo, 2014/03/20