[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 4/7] allwinner-a10-pit: use level triggered inter
From: |
Beniamino Galvani |
Subject: |
[Qemu-devel] [PATCH v4 4/7] allwinner-a10-pit: use level triggered interrupts |
Date: |
Thu, 20 Mar 2014 22:25:16 +0100 |
Convert the interrupt generation logic to the use of level triggered
interrupts.
Signed-off-by: Beniamino Galvani <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
---
hw/timer/allwinner-a10-pit.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/hw/timer/allwinner-a10-pit.c b/hw/timer/allwinner-a10-pit.c
index 696b7d9..5aa78a9 100644
--- a/hw/timer/allwinner-a10-pit.c
+++ b/hw/timer/allwinner-a10-pit.c
@@ -19,6 +19,15 @@
#include "sysemu/sysemu.h"
#include "hw/timer/allwinner-a10-pit.h"
+static void a10_pit_update_irq(AwA10PITState *s)
+{
+ int i;
+
+ for (i = 0; i < AW_A10_PIT_TIMER_NR; i++) {
+ qemu_set_irq(s->irq[i], !!(s->irq_status & s->irq_enable & (1 << i)));
+ }
+}
+
static uint64_t a10_pit_read(void *opaque, hwaddr offset, unsigned size)
{
AwA10PITState *s = AW_A10_PIT(opaque);
@@ -74,9 +83,11 @@ static void a10_pit_write(void *opaque, hwaddr offset,
uint64_t value,
switch (offset) {
case AW_A10_PIT_TIMER_IRQ_EN:
s->irq_enable = value;
+ a10_pit_update_irq(s);
break;
case AW_A10_PIT_TIMER_IRQ_ST:
s->irq_status &= ~value;
+ a10_pit_update_irq(s);
break;
case AW_A10_PIT_TIMER_BASE ... AW_A10_PIT_TIMER_BASE_END:
index = offset & 0xf0;
@@ -178,6 +189,8 @@ static void a10_pit_reset(DeviceState *dev)
s->irq_enable = 0;
s->irq_status = 0;
+ a10_pit_update_irq(s);
+
for (i = 0; i < 6; i++) {
s->control[i] = AW_A10_PIT_DEFAULT_CLOCK;
s->interval[i] = 0;
@@ -203,7 +216,7 @@ static void a10_pit_timer_cb(void *opaque)
ptimer_stop(s->timer[i]);
s->control[i] &= ~AW_A10_PIT_TIMER_EN;
}
- qemu_irq_pulse(s->irq[i]);
+ a10_pit_update_irq(s);
}
}
--
1.7.10.4
- [Qemu-devel] [PATCH v4 0/7] Allwinner A10 fixes, Beniamino Galvani, 2014/03/20
- [Qemu-devel] [PATCH v4 1/7] allwinner-a10-pic: set vector address when an interrupt is pending, Beniamino Galvani, 2014/03/20
- [Qemu-devel] [PATCH v4 2/7] allwinner-a10-pic: fix behaviour of pending register, Beniamino Galvani, 2014/03/20
- [Qemu-devel] [PATCH v4 3/7] allwinner-a10-pit: avoid generation of spurious interrupts, Beniamino Galvani, 2014/03/20
- [Qemu-devel] [PATCH v4 4/7] allwinner-a10-pit: use level triggered interrupts,
Beniamino Galvani <=
- [Qemu-devel] [PATCH v4 6/7] allwinner-emac: set autonegotiation complete bit on link up, Beniamino Galvani, 2014/03/20
- [Qemu-devel] [PATCH v4 7/7] allwinner-emac: update irq status after writes to interrupt registers, Beniamino Galvani, 2014/03/20
- [Qemu-devel] [PATCH v4 5/7] allwinner-a10-pit: implement prescaler and source selection, Beniamino Galvani, 2014/03/20