Re: [Qemu-devel] [PATCH v4 20/21] target-arm: Add Cortex-A57 processor

[Peter Maydell]

On 6 March 2014 19:33, Peter Maydell <address@hidden> wrote:
> Add Cortex-A57 processor.
>
> Signed-off-by: Peter Maydell <address@hidden>

> +static void aarch64_a57_initfn(Object *obj)
> +{
> +    ARMCPU *cpu = ARM_CPU(obj);
> +
> +    set_feature(&cpu->env, ARM_FEATURE_V8);
> +    set_feature(&cpu->env, ARM_FEATURE_VFP4);
> +    set_feature(&cpu->env, ARM_FEATURE_VFP_FP16);
> +    set_feature(&cpu->env, ARM_FEATURE_NEON);
> +    set_feature(&cpu->env, ARM_FEATURE_THUMB2EE);

This last one should be removed, since Thumb2EE is
not present in ARMv8.

thanks
-- PMM