[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL for-2.0 01/13] target-ppc: Add missing 'static' and '
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PULL for-2.0 01/13] target-ppc: Add missing 'static' and 'const' attributes |
Date: |
Thu, 20 Mar 2014 02:48:43 +0100 |
From: Stefan Weil <address@hidden>
This fixes warnings from the static code analysis (smatch).
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
---
target-ppc/arch_dump.c | 6 +++---
target-ppc/int_helper.c | 2 +-
target-ppc/machine.c | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/target-ppc/arch_dump.c b/target-ppc/arch_dump.c
index 17fd4c6..9dccf1a 100644
--- a/target-ppc/arch_dump.c
+++ b/target-ppc/arch_dump.c
@@ -164,7 +164,7 @@ static void ppc64_write_elf64_speregset(Note *note,
PowerPCCPU *cpu)
speregset->spe_fscr = cpu_to_be32(cpu->env.spe_fscr);
}
-struct NoteFuncDescStruct {
+static const struct NoteFuncDescStruct {
int contents_size;
void (*note_contents_func)(Note *note, PowerPCCPU *cpu);
} note_func[] = {
@@ -196,7 +196,7 @@ ssize_t cpu_get_note_size(int class, int machine, int
nr_cpus)
int name_size = 8; /* "CORE" or "QEMU" rounded */
size_t elf_note_size = 0;
int note_head_size;
- NoteFuncDesc *nf;
+ const NoteFuncDesc *nf;
if (class != ELFCLASS64) {
return -1;
@@ -221,7 +221,7 @@ static int ppc64_write_all_elf64_notes(const char
*note_name,
Note note;
int ret = -1;
int note_size;
- NoteFuncDesc *nf;
+ const NoteFuncDesc *nf;
for (nf = note_func; nf->note_contents_func; nf++) {
note.hdr.n_namesz = cpu_to_be32(sizeof(note.name));
diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c
index e14e304..18b54f0 100644
--- a/target-ppc/int_helper.c
+++ b/target-ppc/int_helper.c
@@ -1075,7 +1075,7 @@ void helper_vbpermq(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t
*b)
#undef VBPERMQ_INDEX
#undef VBPERMQ_DW
-uint64_t VGBBD_MASKS[256] = {
+static const uint64_t VGBBD_MASKS[256] = {
0x0000000000000000ull, /* 00 */
0x0000000000000080ull, /* 01 */
0x0000000000008000ull, /* 02 */
diff --git a/target-ppc/machine.c b/target-ppc/machine.c
index 2d46cec..063b379 100644
--- a/target-ppc/machine.c
+++ b/target-ppc/machine.c
@@ -114,7 +114,7 @@ static void put_avr(QEMUFile *f, void *pv, size_t size)
qemu_put_be64(f, v->u64[1]);
}
-const VMStateInfo vmstate_info_avr = {
+static const VMStateInfo vmstate_info_avr = {
.name = "avr",
.get = get_avr,
.put = put_avr,
@@ -288,7 +288,7 @@ static void put_slbe(QEMUFile *f, void *pv, size_t size)
qemu_put_be64(f, v->vsid);
}
-const VMStateInfo vmstate_info_slbe = {
+static const VMStateInfo vmstate_info_slbe = {
.name = "slbe",
.get = get_slbe,
.put = put_slbe,
--
1.8.4.5
- [Qemu-devel] [PULL for-2.0-rc1 00/13] PowerPC patch queue 2014-03-20 #2, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 03/13] target-ppc: Reset SPRs on CPU reset, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 06/13] target-ppc: Introduce powerisa-207-server flag, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 07/13] spapr_hcall: Fix little-endian resource handling in H_SET_MODE, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 09/13] qdev: Introduce FWPathProvider interface, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 04/13] target-ppc: Fix overallocation of opcode tables, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 10/13] spapr_llan: Add to boot device list, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 08/13] vl.c: Extend get_boot_devices_list() to ignore suffixes, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 01/13] target-ppc: Add missing 'static' and 'const' attributes,
Andreas Färber <=
- [Qemu-devel] [PULL for-2.0 05/13] target-ppc: Force CPU threads count to be a power of 2, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 02/13] spapr_hcall: Fix h_enter to loop correctly, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 11/13] spapr_vio: Fix firmware names, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 12/13] spapr: QOM'ify pseries machine, Andreas Färber, 2014/03/19
- [Qemu-devel] [PULL for-2.0 13/13] spapr: Implement interface to fix device pathname, Andreas Färber, 2014/03/19
- Re: [Qemu-devel] [PULL for-2.0-rc1 00/13] PowerPC patch queue 2014-03-20 #2, Peter Maydell, 2014/03/20