[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] block: Replaced old error handling with err
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/3] block: Replaced old error handling with error reporting API. |
|
Date: |
Mon, 17 Mar 2014 16:12:16 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Mar 17, 2014 at 01:10:58AM +0400, Maria Kustova wrote:
> Signed-off-by: Maria Kustova <address@hidden>
> ---
> block/curl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/curl.c b/block/curl.c
> index 3494c6d..359637e 100644
> --- a/block/curl.c
> +++ b/block/curl.c
> @@ -538,7 +538,7 @@ static int curl_open(BlockDriverState *bs, QDict
> *options, int flags,
> return 0;
>
> out:
> - fprintf(stderr, "CURL: Error opening file: %s\n", state->errmsg);
> + error_setg(errp, "CURL: Error opening file: %s\n", state->errmsg);
error_setg() does not require newline at the end of the line. Please
remove the '\n'.