[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/7] allwinner-a10-pic: fix behaviour of pend
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/7] allwinner-a10-pic: fix behaviour of pending register |
Date: |
Mon, 17 Mar 2014 11:00:40 +1000 |
On Sat, Mar 15, 2014 at 11:01 PM, Beniamino Galvani <address@hidden> wrote:
> The pending register is read-only and the value returned upon a read
> reflects the state of irq input pins (interrupts are level triggered).
> This patch implements such behaviour.
>
> Signed-off-by: Beniamino Galvani <address@hidden>
Reviewed-by: Peter Crosthwaite <address@hidden>
> ---
> hw/intc/allwinner-a10-pic.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/hw/intc/allwinner-a10-pic.c b/hw/intc/allwinner-a10-pic.c
> index 00f3c11..0924d98 100644
> --- a/hw/intc/allwinner-a10-pic.c
> +++ b/hw/intc/allwinner-a10-pic.c
> @@ -49,6 +49,8 @@ static void aw_a10_pic_set_irq(void *opaque, int irq, int
> level)
>
> if (level) {
> set_bit(irq % 32, (void *)&s->irq_pending[irq / 32]);
> + } else {
> + clear_bit(irq % 32, (void *)&s->irq_pending[irq / 32]);
> }
> aw_a10_pic_update(s);
> }
> @@ -102,7 +104,11 @@ static void aw_a10_pic_write(void *opaque, hwaddr
> offset, uint64_t value,
> s->nmi = value;
> break;
> case AW_A10_PIC_IRQ_PENDING ... AW_A10_PIC_IRQ_PENDING + 8:
> - s->irq_pending[index] &= ~value;
> + /*
> + * The register is read-only; nevertheless, Linux (including
> + * the version originally shipped by Allwinner) pretends to
> + * write to the register. Just ignore it.
> + */
> break;
> case AW_A10_PIC_FIQ_PENDING ... AW_A10_PIC_FIQ_PENDING + 8:
> s->fiq_pending[index] &= ~value;
> --
> 1.7.10.4
>
>
- [Qemu-devel] [PATCH v3 0/7] Allwinner A10 fixes, Beniamino Galvani, 2014/03/15
- [Qemu-devel] [PATCH v3 1/7] allwinner-a10-pic: set vector address when an interrupt is pending, Beniamino Galvani, 2014/03/15
- [Qemu-devel] [PATCH v3 2/7] allwinner-a10-pic: fix behaviour of pending register, Beniamino Galvani, 2014/03/15
- [Qemu-devel] [PATCH v3 3/7] allwinner-a10-pit: avoid generation of spurious interrupts, Beniamino Galvani, 2014/03/15
- [Qemu-devel] [PATCH v3 7/7] allwinner-emac: update irq status after writes to interrupt registers, Beniamino Galvani, 2014/03/15
- [Qemu-devel] [PATCH v3 4/7] allwinner-a10-pit: use level triggered interrupts, Beniamino Galvani, 2014/03/15
- [Qemu-devel] [PATCH v3 5/7] allwinner-a10-pit: implement prescaler and source selection, Beniamino Galvani, 2014/03/15